Messages in this thread | | | Date | Thu, 8 Oct 2009 20:34:32 +0200 | From | Frederic Weisbecker <> | Subject | Re: [PATCH] perf tools: Improve thread comm resolution in perf sched |
| |
On Thu, Oct 08, 2009 at 07:18:16PM +0200, Frederic Weisbecker wrote: > On Thu, Oct 08, 2009 at 06:33:02PM +0200, Peter Zijlstra wrote: > > On Thu, 2009-10-08 at 16:37 +0200, Frederic Weisbecker wrote: > > > When we get sched traces that involve a task that was already > > > created before opening the event, we won't have the comm event > > > for it. > > > > pid_synthesize_comm_event() should have taken care of that.. > > > > > So if we can't find the comm event for a given thread, we look at the > > > traces that may contain these informations. > > > > Sure, but it would be good to find out why the synthesize bits didn't > > work as expected. > > > Oh you're right, I didn't notice it. > > And it's weird, I've just done some tests, and I always > have the same pids that are found inside the events but > but not in /proc: > > 7989 -> npviewer.bin > 5467 -> xchat > 5124 -> firefox > 7929 -> npviewer.bin > > That's weird. I'm going to look further on the proc filesystem. >
Geeze...this is just because we are resolving the pid, not the tid..
The patch is actually a one liner :-(
| |