Messages in this thread | | | Subject | Re: [BUG] wbsd.c: after spin_lock_bh uses spin_unlock instead spin_unlock_bh | From | Peter Zijlstra <> | Date | Thu, 08 Oct 2009 20:20:25 +0200 |
| |
On Thu, 2009-10-08 at 15:18 +0000, Alexander Strakh wrote: > KERNEL_VERSION: 2.6.31 > DESCRIBE: > Driver ./drivers/mmc/host/wbsd.c calls spin_lock_bh and then spin_unlock > instead of spin_unlock_bh: > > 753 static void wbsd_request(struct mmc_host *mmc, struct mmc_request *mrq) > .... > 761 spin_lock_bh(&host->lock); > .... > 844 done: > 845 wbsd_request_end(host, mrq); > 846 > 847 spin_unlock_bh(&host->lock); > 848 } > > But in wsdb_request calls spin_unlock/spin_lock instead of > spin_unlock_bh/spin_lock_bh; > > 206 static void wbsd_request_end(struct wbsd_host *host, struct mmc_request > .... > 230 spin_unlock(&host->lock); > 231 mmc_request_done(host->mmc, mrq); > 232 spin_lock(&host->lock); > 233 }
Doesn't look too odd, it simply leaves BH disabled, but unlocks the spinlock.
| |