lkml.org 
[lkml]   [2009]   [Oct]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
SubjectRe: linux-next: mfd tree build failure
From
> -----Original Message-----
> From: Stephen Rothwell [mailto:sfr@canb.auug.org.au]
> Sent: 2009年10月6日 11:54 AM
> To: Haojian Zhuang
> Cc: Samuel Ortiz; linux-next@vger.kernel.org; linux-kernel@vger.kernel.org; Mark Brown
> Subject: Re: linux-next: mfd tree build failure
>
> Hi Haojian,
>
> On Mon, 5 Oct 2009 19:35:05 -0700 Haojian Zhuang <hzhuang1@marvell.com> wrote:
>>
>> Could you send your .config file to me? The 88pm8607 patch is just for mfd-2.6 git tree. I didn't try it in linux-next git tree before. I can try it now. If I could have your .config file, it would be better.
>
> I am sorry, but I don't have the exact .config file any more (I have
> moved on in my creation of linux-next) however, as I said, this was an
> allmodconfig build on x86_64. I also noted that CONFIG_I2C=m and
> CONFIG_MFD_CORE=m, while the config entry that controls the building of
> this driver is a bool so must have been 'y'. So from a builtin driver,
> you are referring to symbols that are only defined in modules.
>
> --
> Cheers,
> Stephen Rothwell sfr@canb.auug.org.au
> http://www.canb.auug.org.au/~sfr/
>

Hi Stephen & Samuel,

Please ignore the original fix patch on 88pm8607 dependancy. I write a
new patch on it and paste it in below. Please help to review it.

Thanks
Haojian

From 26174b67184759ac2fe33748eeb43d3738732e21 Mon Sep 17 00:00:00 2001
From: Haojian Zhuang <haojian.zhuang@marvell.com>
Date: Thu, 8 Oct 2009 09:07:05 -0400
Subject: [PATCH] mfd: fix the dependancy of 88PM8607

88PM8607 module is dependant on I2C. I2C module must be built-in.

Signed-off-by: Haojian Zhuang <haojian.zhuang@marvell.com>
---
drivers/mfd/Kconfig | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
index fbe684b..00064e2 100644
--- a/drivers/mfd/Kconfig
+++ b/drivers/mfd/Kconfig
@@ -307,7 +307,7 @@ config EZX_PCAP

config MFD_88PM8607
bool "Support Marvell 88PM8607"
- depends on I2C
+ depends on I2C=y
select MFD_CORE
help
This supports for Marvell 88PM8607 Power Management IC. This includes
--
1.5.6.5
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
\
 
 \ /
  Last update: 2009-10-08 08:07    [W:1.909 / U:0.012 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site