[lkml]   [2009]   [Oct]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH 7/9] KVM: SVM: Add tracepoint for invlpga instruction
    On Thu, Oct 08, 2009 at 06:01:55PM +0200, Avi Kivity wrote:
    > On 10/08/2009 12:03 PM, Joerg Roedel wrote:
    > >This patch adds a tracepoint for the event that the guest
    > >executed the INVLPGA instruction.
    > >+
    > >+ TP_printk("rip=0x%016llx asid=%d adress=0x%016llx\n",
    > >+ __entry->rip, __entry->asid, __entry->address)
    > >+);
    > s/adress/address/.
    > Also, kvm tracepoints don't use '=' in TP_printk(), please keep it
    > consistent.

    I had it with "key: value" formating first but decided to do it this way
    because it simplifies automatic parsing of these trace events. With this
    format a script can first split by spaces and get the key-value pairs by
    splitting on the equal sign. This is also more robust against changes in
    the format.


     \ /
      Last update: 2009-10-08 18:23    [from the cache]
    ©2003-2014 Jasper Spaans. hosted at Digital Ocean