Messages in this thread | | | Date | Thu, 8 Oct 2009 14:13:53 +0100 | From | Alan Cox <> | Subject | Re: [PATCH 2/4] isicom: switch to the new tty_port_open helper |
| |
On Wed, 07 Oct 2009 22:11:01 +0200 Jiri Slaby <jirislaby@gmail.com> wrote:
> On 10/07/2009 04:46 PM, Alan Cox wrote: > > - if (port->port.flags & ASYNC_INITIALIZED) > > - return 0; > > - if (tty_port_alloc_xmit_buf(&port->port) < 0) > > + if (tty_port_alloc_xmit_buf(tport) < 0) > > I think this won't work well with 1/4. ->activate is called with > port->port.mutex (the name in this context), but tty_port_alloc_xmit_buf > wants it again.
Ok fixed that the simple way the buffer allocator now has its own private mutex. Any other problems strike you ?
| |