Messages in this thread | | | Subject | Re: [RFC][PATCH 5/9] perf trace: Add Perl scripting support | From | Tom Zanussi <> | Date | Tue, 06 Oct 2009 23:09:25 -0500 |
| |
On Tue, 2009-10-06 at 15:00 +0200, Ingo Molnar wrote: > * Tom Zanussi <tzanussi@gmail.com> wrote: > > > OPT_BOOLEAN('v', "verbose", &verbose, > > "be more verbose (show symbol address, etc)"), > > + OPT_BOOLEAN('p', "perl", &do_perl, > > + "send output to a Perl script"), > > OPT_STRING('s', "script", &script_name, "file", > > "script file name"), > > I dont think we want to use up primary option letters one per language. > If Perl takes 'p' then what will Python use, 'P'? How about PHP, PEARL > and PostScript then? ;-) > > I think it's better to make the language specification part of the > -s/--script option, via two methods: > > Explicit: > > -s Perl::my_script.pl > -s pl::my_script.pl > -s Python::my_script.py > -s Bash::my_script.sh > > Implicit, based on the script extension: > > -s my_script.pl # maps to the Perl generator > -s my_script.py # maps to the Python generator > -s my_script.sh # maps to the Bash generator > > I think we also want to have a 'perf -s *' kind of thing to get a list > of all available language modules. >
I knew somebody would point that out (and suggest a better way ;-) That all makes sense - I'll make these changes in the next version.
Tom
> Ingo
| |