[lkml]   [2009]   [Oct]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [TOMOYO #16 00/25] Starting TOMOYO 2.3

Pavel Machek wrote:
>> Since this patchset is not yet accepted, I haven't written documentation for
>> TOMOYO 2.3. You can see
>> instead.
>New, undocumented user/kernel api is no-no.

I'll update api description by final submission.

Main purpose of this submission is to

(1) know whether 01, 02, 03, 05 and 06 are acceptable or not.
If 05 is not acceptable, the rest of patchset needs to be rewritten.
Please review 01, 02, 03, 05 and 06 before reviewing the rest.

(2) know which features are acceptable.
This submission includes proposal of new features.

Use of customized d_path().
Network filtering including incoming TCP connections.
Audit logs.
Conditional permissions.
Interactive enforcing mode.
Sleep penalty.
Execute handler.
Environment variable name checking.
Non POSIX capability checking.

Unacceptable features will be dropped from next submission.

>> Conventionally, patches should be submitted in the form of diff file.
>> But this time, I submit in the form of entire file due to amount of changes.
> That's also no-no.

I have a question.
Is the diff file based on existing files more preferable for reviewers to
review than totally rewritten files, even if "total lines of diff files" is
close to "total lines of rewritten files"?

Amount of rewritten files:
# cat security/tomoyo/* | wc -l

Amount of diff based on existing files:
# diff -Nur security/tomoyo.2.2/ security/tomoyo/ | wc -l
# diff -Nur security/tomoyo.2.2/ security/tomoyo/ | diffstat -f0
24 files changed, 13495 insertions(+), 2216 deletions(-)

I posted rewritten files because I thought reading 17250 insertions is less
difficult than reading 16945 lines of diff file with complicated mixture of
13495 insertions and 2216 deletions.


 \ /
  Last update: 2009-10-07 06:15    [W:0.221 / U:3.688 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site