Messages in this thread | | | Date | Wed, 7 Oct 2009 11:43:09 -0700 | Subject | Re: [PATCH 5/7] x86/PCI: print resources consistently with %pRt | From | Yinghai Lu <> |
| |
On Tue, Oct 6, 2009 at 2:33 PM, Bjorn Helgaas <bjorn.helgaas@hp.com> wrote: > This uses %pRt to print additional resource information (type, size, > prefetchability, etc.) consistently. > > Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com> > --- > arch/x86/pci/acpi.c | 14 +++++++++++--- > arch/x86/pci/i386.c | 12 +++++------- > 2 files changed, 16 insertions(+), 10 deletions(-) > > diff --git a/arch/x86/pci/acpi.c b/arch/x86/pci/acpi.c > index 2297280..4d4f1df 100644 > --- a/arch/x86/pci/acpi.c > +++ b/arch/x86/pci/acpi.c > @@ -7,6 +7,7 @@ > #include <asm/pci_x86.h> > > struct pci_root_info { > + struct acpi_device *bridge; > char *name; > unsigned int res_num; > struct resource *res; > @@ -107,12 +108,18 @@ setup_resource(struct acpi_resource *acpi_res, void *data) > res->child = NULL; > > if (insert_resource(root, res)) { > - printk(KERN_ERR "PCI: Failed to allocate 0x%lx-0x%lx " > - "from %s for %s\n", (unsigned long) res->start, > - (unsigned long) res->end, root->name, info->name); > + dev_err(&info->bridge->dev, "can't allocate %pRt\n", res);
better to keep that root name ?
YH -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |