Messages in this thread | | | Subject | Re: [PATCH 1/7] printk: clean up return value | From | Joe Perches <> | Date | Wed, 07 Oct 2009 06:55:02 -0700 |
| |
On Wed, 2009-10-07 at 09:39 +0100, Alan Jenkins wrote: > Commit 5fd29d6 "printk: clean up handling of log-levels and newlines" > causes printk() to return the wrong number of characters.
Maybe it'd be better to return void?
These may be the only uses of the value returned, and both files are trivial to modify.
kernel/lockdep.c: len += printk("%*s %s", depth, "", usage_str[bit]); kernel/lockdep.c: len += printk(" at:\n"); drivers/char/mem.c: ret = printk("%s", tmp);
| |