lkml.org 
[lkml]   [2009]   [Oct]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 4/5] usb_serial: Kill port mutex
Date
Am Dienstag, 6. Oktober 2009 17:06:46 schrieb Alan Cox:
> +++ b/drivers/usb/serial/opticon.c
> @@ -498,12 +498,12 @@ static int opticon_resume(struct usb_interface *intf)
>         struct usb_serial_port *port = serial->port[0];
>         int result;
>  
> -       mutex_lock(&port->mutex);
> +       mutex_lock(&port->port.mutex);
>         if (port->port.count)
>                 result = usb_submit_urb(priv->bulk_read_urb, GFP_NOIO);
>         else
>                 result = 0;
> -       mutex_unlock(&port->mutex);
> +       mutex_unlock(&port->port.mutex);
>         return result;
>  }

We will need some generic way to autoresume from open.
Resume will need to lock against open() and need to be called
from within open(). Any ideas for an unugly interface?

Regards
Oliver

\
 
 \ /
  Last update: 2009-10-07 07:07    [W:0.485 / U:0.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site