Messages in this thread | | | Subject | Re: [v7 PATCH 0/7]: cpuidle/x86/POWER: Cleanup idle power management code in x86, cleanup drivers/cpuidle/cpuidle.c and introduce cpuidle to POWER. | From | Peter Zijlstra <> | Date | Wed, 07 Oct 2009 15:24:17 +0200 |
| |
On Wed, 2009-10-07 at 17:17 +0530, Balbir Singh wrote:
> > The objective of the refactoring is to have a single common idle > > routine management framework (remove pm_idle) and we have it done > > through cpuidle registration framework. We can incrementally remove > > the per-cpu registration later easily by splitting the cpuidle_driver > > structure. > > > > Yes, incremental refactoring makes the most sense from the do not > break as you refactor point of view.
Sure,.. but I would have though getting rid of the per-cpu-ish-ness would have made the latter patches in this series easier. But maybe I'm lazy ;-)
Let me go over the patches one more time, but they do look ok.
| |