lkml.org 
[lkml]   [2009]   [Oct]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH 07/19] stop_machine: reimplement without using workqueue
    Date
    On Thu, 1 Oct 2009 05:39:06 pm Tejun Heo wrote:
    > stop_machine() is the only user of RT workqueue. Reimplement it using
    > kthreads directly and rip RT support from workqueue. This is in
    > preparation of concurrency managed workqueue.

    Seems reasonable, but:

    > void stop_machine_destroy(void)
    > {
    > + get_online_cpus();
    > mutex_lock(&setup_lock);

    Did you test hotplug cpu after this change? Maybe this works fine, but it's
    always the one we break when we play with this code :(

    Thanks!
    Rusty.


    \
     
     \ /
      Last update: 2009-10-07 01:31    [W:0.020 / U:64.012 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site