Messages in this thread | | | Date | Tue, 6 Oct 2009 23:19:55 +0100 | From | Alan Cox <> | Subject | Re: [PATCH] Integrating SEP Driver with RAR Driver |
| |
> +#define SEP_IOCTLSETCALLERID _IO(SEP_IOC_MAGIC_NUMBER , 33)
_IOR _IOW etc... I pointed this out before and it's not fixed
> struct sep_driver_realloc_cache_resident_t { > - /* new cache address */ > - u64 new_cache_addr; > - /* new resident address */ > - u64 new_resident_addr; > - /* new resident address */ > - u64 new_shared_area_addr; > - /* new base address */ > - u64 new_base_addr; > -}; > + /* base address */ > + unsigned long base_addr;
and the ioctls still need to be fixed for 32/64bit
> +/* debug macro with 3 paramaters */ > +#define DEBUG_PRINT_3(DEBUG_LEVEL, info, param1, param2, param3) \ > +do { \ > + if (DEBUG_LEVEL & sepDebug) \ > + printk(KERN_WARNING info , param1, param2 , param3); \ > +} while (0)
And the debug helpers are a step back
Sorry but this is basically undoing a lot of cleanup that was needed.
To put it mildly this needs a lot of further discussion before anything goes into the code.
| |