lkml.org 
[lkml]   [2009]   [Oct]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v3] mfd: ADP5520 Multifunction LCD Backlight and Keypad Input Device Driver
    On Tue, Oct 06, 2009 at 03:44:31AM -0400, Mike Frysinger wrote:

    > +int adp5520_register_notifier(struct device *dev, struct notifier_block *nb,
    > + unsigned int events)
    > +{

    This notifier stuff looks an awful lot like an interrupt controller
    driver. Now that it's possible to implement support for an I2C/SPI
    driven interrupt controller it'd be good to use that rather than having
    a custom API if that's possible.

    > +#define GPIO_R3 (1 << 3) /* LED3 or GPIO3 aka R3 */
    > +#define GPIO_R2 (1 << 2)
    > +#define GPIO_R1 (1 << 1)
    > +#define GPIO_R0 (1 << 0)

    > +struct adp5520_gpio_platfrom_data {
    > + unsigned gpio_start;
    > + u8 gpio_en_mask;
    > + u8 gpio_pullup_mask;
    > +};

    Since there's platform data in here it'd probably be better to namespace
    the #defines or put them in a separate header in case there are
    collisions with some other chip used on a board.

    > +struct adp5520_leds_platfrom_data {

    There's some 'platfrom' rather than 'platform' typos.

    > + int num_leds;
    > + struct led_info *leds;
    > + u8 fade_in; /* Backlight Fade-In Timer */
    > + u8 fade_out; /* Backlight Fade-Out Timer */
    > + u8 led_on_time;

    I don't know exactly what the on_time option does but if it controls
    hardware-implemented blinking there's actually a callback function the
    LED driver can implement to allow triggers to use the hardware assisted
    blinking at runtime. If it returns an error or isn't implemented
    there's a software fallback.


    \
     
     \ /
      Last update: 2009-10-06 14:05    [W:2.118 / U:0.544 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site