Messages in this thread | | | From | "Rafael J. Wysocki" <> | Subject | Re: Help needed, Re: [Bug #14334] pcmcia suspend regression from 2.6.31.1 to 2.6.31.2 - Dell Inspiron 600m | Date | Sat, 31 Oct 2009 23:10:24 +0100 |
| |
On Saturday 31 October 2009, Linus Torvalds wrote: > > On Sat, 31 Oct 2009, Rafael J. Wysocki wrote: > > > > Yes, there is, because socket_early_resume() only does it in > > the (skt->state & SOCKET_PRESENT) case. If that bit is not set, the > > initialization is entirely postponed. > > Ahh, ok. And what's the reason for that? It seems like the > > skt->socket = dead_socket; > skt->ops->init(skt); > skt->ops->set_socket(skt, &skt->socket); > > thing should always be safe, whether there is something present or not.. ?
It should, but I'm not sure given the reported behavior so far.
I guess I'll prepare another patch that does this unconditionally in the early phase and let's see how that works.
Rafael
| |