lkml.org 
[lkml]   [2009]   [Oct]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 03/16] trivial: fix assorted "through" typos
Am 31.10.2009 11:17 schrieb Nigel Cunningham:
> I've only looked at this one, but something caught my eye...
>
> André Goddard Rosa wrote:
>> diff --git a/arch/blackfin/kernel/cplb-mpu/cplbinit.c
>> b/arch/blackfin/kernel/cplb-mpu/cplbinit.c
>> index f7b9cdc..b52c1f8 100644
>> --- a/arch/blackfin/kernel/cplb-mpu/cplbinit.c
>> +++ b/arch/blackfin/kernel/cplb-mpu/cplbinit.c
>> @@ -38,7 +38,7 @@ void __init generate_cplb_tables_cpu(unsigned int cpu)
>>
>> #ifdef CONFIG_BFIN_EXTMEM_DCACHEABLE
>> d_cache = CPLB_L1_CHBL;
>> -#ifdef CONFIG_BFIN_EXTMEM_WRITETROUGH
>> +#ifdef CONFIG_BFIN_EXTMEM_WRITETHROUGH
>> d_cache |= CPLB_L1_AOW | CPLB_WT;
>> #endif
>> #endif
>
> "Surely that can't be the only time?", I thought. But it is - all of the
> other #ifdefs are spelled correctly, so you're probably fixing a
> hard-to-find bug here! Good catch!
>
> Makes me wonder if anyone's written a tool to find things like this -
> #ifdefs that will never be defined...

I seem to remember someone (Joe Perches?) did, and regularly posted
results to LKML in the past, but at some point switched to publishing
them on a web page instead.

--
Tilman Schmidt E-Mail: tilman@imap.cc
Bonn, Germany
Diese Nachricht besteht zu 100% aus wiederverwerteten Bits.
Ungeöffnet mindestens haltbar bis: (siehe Rückseite)

[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2009-10-31 13:13    [from the cache]
©2003-2011 Jasper Spaans