lkml.org 
[lkml]   [2009]   [Oct]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] x86, apicdef: Fix checkpatch issues in apicdef.h
[Rakib Mullick - Sat, Oct 31, 2009 at 03:29:32PM +0600]
|
| In apicdef.h - we have a checkpatch issue - needs to be fixed.
| We were warned by the following checkpatch warning:
|
| ERROR: space prohibited before that ':' (ctx:WxW)
| #276: FILE: arch/x86/include/asm/apicdef.h:376:
| + hi : 1;
| ^
| ---
| Signed-off-by: Rakib Mullick <rakib.mullick@gmail.com>
|

Hi Rakib,

personally I would not change it even having checkpatch
issue. Really, it's easier to read this bitfield width
aligned rather then moved left. But this is a personal
opinion only (sorry).

-- Cyrill


\
 
 \ /
  Last update: 2009-10-31 11:17    [W:0.081 / U:2.036 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site