lkml.org 
[lkml]   [2009]   [Oct]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectRe: [PATCH] USB: ftdi_sio: Remove tty->low_latency.
    On Sat, Oct 03, 2009 at 05:33:24PM +0100, Alan Cox wrote:
    > > Of course -- the "with low latency set" part fell out (or, was implicit
    > > ;-) ). Your patch, however, still has low_latency set when it calls
    > > tty_flip_buffer_push and that's the problem.
    >
    > I don't think it does - I removed all the low latency setting.

    It's still in the patch you posted (and ASYNC_LOW_LATENCY is left
    unmodifed, that is set, by your patch):

    @@ -1700,9 +1697,6 @@ static int ftdi_open(struct tty_struct *tty, struct usb_serial_port *port)
    spin_lock_irqsave(&priv->tx_lock, flags);
    priv->tx_bytes = 0;
    spin_unlock_irqrestore(&priv->tx_lock, flags);
    - spin_lock_irqsave(&priv->rx_lock, flags);
    - priv->rx_bytes = 0;
    - spin_unlock_irqrestore(&priv->rx_lock, flags);

    if (tty)
    tty->low_latency = (priv->flags & ASYNC_LOW_LATENCY) ? 1 : 0;
    @@ -1730,7 +1724,6 @@ static int ftdi_open(struct tty_struct *tty, struct usb_serial_port *port)
    spin_unlock_irqrestore(&priv->rx_lock, flags);

    /* Start reading from the device */
    - priv->rx_processed = 0;
    usb_fill_bulk_urb(port->read_urb, dev,
    usb_rcvbulkpipe(dev, port->bulk_in_endpointAddress),
    port->read_urb->transfer_buffer,

    But nevermind, we agree it should go. :-)



    \
     
     \ /
      Last update: 2009-10-03 18:53    [W:0.023 / U:32.844 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site