lkml.org 
[lkml]   [2009]   [Oct]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] hso: fix debug routines
    On Tue, 27 Oct 2009 16:26:55 +0200
    Antti Kaijanmäki <antti.kaijanmaki@nomovok.com> wrote:

    > On Mon, 2009-10-26 at 12:40 -0700, Greg KH wrote:
    > > Yes, that should be a new patch, especially as it would not be needed
    > > to fix older kernels for the original bug.
    > >
    > > So, care to send 2 patches? The debug one isn't needed to be sent to
    > > the stable@kernel.org address.
    >
    >
    > Signed-off-by: Antti Kaijanmäki <antti.kaijanmaki@nomovok.com>
    > ---
    > drivers/net/usb/hso.c | 4 ++--
    > 1 files changed, 2 insertions(+), 2 deletions(-)
    >
    > diff --git a/drivers/net/usb/hso.c b/drivers/net/usb/hso.c
    > index fa4e581..746839b 100644
    > --- a/drivers/net/usb/hso.c
    > +++ b/drivers/net/usb/hso.c
    > @@ -378,7 +378,7 @@ static void dbg_dump(int line_count, const char *func_name, unsigned char *buf,
    > }
    >
    > #define DUMP(buf_, len_) \
    > - dbg_dump(__LINE__, __func__, buf_, len_)
    > + dbg_dump(__LINE__, __func__, (unsigned char *)buf_, len_)
    >
    > #define DUMP1(buf_, len_) \
    > do { \
    > @@ -1527,7 +1527,7 @@ static void tiocmget_intr_callback(struct urb *urb)
    > dev_warn(&usb->dev,
    > "hso received invalid serial state notification\n");
    > DUMP(serial_state_notification,
    > - sizeof(hso_serial_state_notifation))
    > + sizeof(struct hso_serial_state_notification));
    > } else {
    >
    > UART_state_bitmap = le16_to_cpu(serial_state_notification->

    This patch has no changelog, and I'm not seeing any description of what
    it fixes and how it fixes it up-thread.
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2009-10-29 00:19    [W:3.623 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site