Messages in this thread | | | Date | Wed, 28 Oct 2009 06:19:25 +0100 | From | Andi Kleen <> | Subject | Re: [patch v2] x86: reduce srat verbosity in the kernel log |
| |
> + /* > + * If the bitmap cannot be listed in a buffer of length > + * APICID_LIST_LEN, then it is suffixed with "...". > + */ > + len = bitmap_scnlistprintf(apicid_list, APICID_LIST_LEN, > + apicid_map, MAX_LOCAL_APIC); > + pr_info("SRAT: PXM %u -> APIC {%s%s} -> Node %u\n", > + i, apicid_list, > + (len == APICID_LIST_LEN - 1) ? "..." : "",
Is the - 1 really correct? If scnlistprintf follows snprintf semantics then it would not be and my understanding is it is supposed to.
Other than that it looks good.
-Andi
-- ak@linux.intel.com -- Speaking for myself only.
| |