lkml.org 
[lkml]   [2009]   [Oct]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch] x86: reduce srat verbosity in the kernel log


Andi Kleen wrote:
>> MAX_LOCAL_APIC was definitely an arbitrary choice here and has very little
>> relevance. scnlistprintf will protect against overflow, but we still need
>> to decide upon a constant that will emit the most information possible
>> while not overly polluting the printk and saving on bss, as you mentioned.
>> I suspect we could agree on a value as little as 128 and it would work for
>> the overwhelming majority (all?) of users.
>
> For now at least seems reasonable to limit to 128 or so yes (and go
> back to the stack). if we ever have sparse apic ids for nodes
> then that might change; but in this case could still just do
> a acpidump or teach the printer to be more clever and support
> strides.
>
> It would be just good to have some indication in the output
> if there was a overflow.
>
> -Andi
>

I don't understand the importance of this when the memory is given back
after the system starts up anyway...?

Thanks,
Mike


\
 
 \ /
  Last update: 2009-10-28 18:05    [W:1.110 / U:0.052 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site