Messages in this thread | | | Date | Wed, 28 Oct 2009 05:16:31 -0700 (PDT) | Subject | Re: is avoiding compat ioctls possible? | From | David Miller <> |
| |
From: Arnd Bergmann <arndbergmann@googlemail.com> Date: Wed, 28 Oct 2009 13:13:32 +0100
> The ioctl argument actually needs a compat_ptr() conversion as well. > For the s390 case, we can't do that in common code, because some > ioctl methods put a 32 bit integer into the argument. Not sure if we > want to fix that everywhere, the problem is very common and the > impact is minimal.
What does s390 do with the 'arg' argument to sys_ioctl()?
That assumption that you can cast this to a pointer is everywhere.
If someone wants to fix this up, feel free to do an audit and go over that seperately from my work :-)
| |