lkml.org 
[lkml]   [2009]   [Oct]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] 2.6.32-rc5 bug in Palm Tungsten C keyboard
Date
Dne Út 27. října 2009 08:43:44 Eric Miao napsal(a):
> On Tue, Oct 27, 2009 at 6:59 AM, Ondrej Zajicek <santiago@crfreenet.org>
wrote:
> > Palm Tungsten C keyboard structure has swapped
> > rows/cols gpio structures and does not work.
> > This patch fixes it.
> >
> > Signed-off-by: Ondrej Zajicek <santiago@crfreenet.org>
>
> This fix looks obvious to me. Applied to 'fix'.

Just wondering ... you checked the GPIO directions, right ? I mean, it works in
both directions, it just works worse the other one. I can't really check now.

Also, it'll be possibly good to use the following emails for pxa patches:
Eric Miao <eric.y.miao@gmail.com>
Linux-ARM-Kernel <linux-arm-kernel@lists.infradead.org>
Marek Vasut <marek.vasut@gmail.com>

Those should be enough.

Cheers!
>
> > diff -uprN linux-2.6.32-rc5-old/arch/arm/mach-pxa/palmtc.c
> > linux-2.6.32-rc5/arch/arm/mach-pxa/palmtc.c ---
> > linux-2.6.32-rc5-old/arch/arm/mach-pxa/palmtc.c 2009-10-16
> > 02:41:50.000000000 +0200 +++ linux-2.6.32-rc5/arch/arm/mach-pxa/palmtc.c
> > 2009-10-26 20:56:44.000000000 +0100 @@ -292,10 +292,10 @@ const static
> > unsigned int palmtc_keypad_
> >
> > static struct matrix_keypad_platform_data palmtc_keypad_platform_data =
> > { .keymap_data = &palmtc_keymap_data,
> > - .col_gpios = palmtc_keypad_row_gpios,
> > - .num_col_gpios = 12,
> > - .row_gpios = palmtc_keypad_col_gpios,
> > - .num_row_gpios = 4,
> > + .row_gpios = palmtc_keypad_row_gpios,
> > + .num_row_gpios = ARRAY_SIZE(palmtc_keypad_row_gpios),
> > + .col_gpios = palmtc_keypad_col_gpios,
> > + .num_col_gpios = ARRAY_SIZE(palmtc_keypad_col_gpios),
> > .active_low = 1,
> >
> > .debounce_ms = 20,
> >
> >
> > --
> > Elen sila lumenn' omentielvo
> >
> > Ondrej 'SanTiago' Zajicek (email: santiago@crfreenet.org)
> > OpenPGP encrypted e-mails preferred (KeyID 0x11DEADC3, wwwkeys.pgp.net)
> > "To err is human -- to blame it on a computer is even more so."
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2009-10-28 02:41    [W:0.039 / U:0.328 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site