lkml.org 
[lkml]   [2009]   [Oct]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH -tip perf/probes 07/10] perf/probes: Exit searching after finding target function
    Date
    Exit searching after finding real (not-inlined) function, because
    there should be no same symbol in that CU.

    Signed-off-by: Masami Hiramatsu <mhiramat@redhat.com>
    Cc: Ingo Molnar <mingo@elte.hu>
    Cc: Steven Rostedt <rostedt@goodmis.org>
    Cc: Jim Keniston <jkenisto@us.ibm.com>
    Cc: Ananth N Mavinakayanahalli <ananth@in.ibm.com>
    Cc: Christoph Hellwig <hch@infradead.org>
    Cc: Frank Ch. Eigler <fche@redhat.com>
    Cc: Frederic Weisbecker <fweisbec@gmail.com>
    Cc: H. Peter Anvin <hpa@zytor.com>
    Cc: Jason Baron <jbaron@redhat.com>
    Cc: K.Prasad <prasad@linux.vnet.ibm.com>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
    ---

    tools/perf/util/probe-finder.c | 4 ++--
    1 files changed, 2 insertions(+), 2 deletions(-)

    diff --git a/tools/perf/util/probe-finder.c b/tools/perf/util/probe-finder.c
    index 54e7071..b98d35e 100644
    --- a/tools/perf/util/probe-finder.c
    +++ b/tools/perf/util/probe-finder.c
    @@ -585,14 +585,14 @@ static int probefunc_callback(struct die_link *dlink, void *data)
    DIE_IF(ret != DW_DLV_OK);
    pr_debug("inline definition offset %lld\n",
    pf->inl_offs);
    - return 0;
    + return 0; /* Continue to search */
    }
    /* Get probe address */
    pf->addr = die_get_entrypc(dlink->die);
    pf->addr += pp->offset;
    /* TODO: Check the address in this function */
    show_probepoint(dlink->die, pp->offset, pf);
    - /* Continue to search */
    + return 1; /* Exit; no same symbol in this CU. */
    }
    } else if (tag == DW_TAG_inlined_subroutine && pf->inl_offs) {
    if (die_get_abstract_origin(dlink->die) == pf->inl_offs) {

    --
    Masami Hiramatsu

    Software Engineer
    Hitachi Computer Products (America), Inc.
    Software Solutions Division

    e-mail: mhiramat@redhat.com


    \
     
     \ /
      Last update: 2009-10-27 21:47    [W:0.021 / U:34.892 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site