lkml.org 
[lkml]   [2009]   [Oct]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 3/3 v2] at91/atmel-mci: inclusion of sd/mmc driver in at91sam9g45 chip and board
    From
    hi Nicolas,

    > +       if (data->slot[0].wp_pin)
    > +               at91_set_gpio_input(data->slot[0].wp_pin, 1);

    > +static struct mci_platform_data __initdata mci0_data = {
    > +       .slot[0] = {
    > +               .bus_width      = 4,
    > +               .detect_pin     = AT91_PIN_PD10,
    > +               .wp_pin         = -1,
    > +       },

    Causes at91_set_gpio_input() to be called for pin -1. Which shouldn't be valid.
    AT91 platforms use 0 to indicate an un-connected GPIO pin, so the
    assignment of "wp_pin" should probably just be removed.


    Regards,
    Andrew Victor
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2009-10-27 20:45    [W:3.242 / U:0.068 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site