lkml.org 
[lkml]   [2009]   [Oct]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] net: Adjust softirq raising in __napi_schedule
    On Fri, Oct 23, 2009 at 04:46:31PM +0200, Johannes Berg wrote:
    > On Fri, 2009-10-23 at 16:39 +0200, Tilman Schmidt wrote:
    >
    > > Strange. Then what are the two separate functions netif_rx() and
    > > netif_rx_ni() for?
    >
    > netif_rx_ni() disables preemption.

    You wrote earlier:

    > [...] the networking layer needs to have
    > packets handed to it with softirqs disabled.

    How disabling preemption can fix something which needs softirqs
    disabled? Could you be more precise?

    > > > This really should be obvious. You're fixing the warning at the source
    > > > of the warning, rather than the source of the problem.
    > >
    > > Good idea. So please do tell us where the source of the problem is.
    >
    > You use netif_rx_ni() instead of netif_rx() at whatever place that
    > causes this problem.

    This isn't a very precise description either.

    Jarek P.


    \
     
     \ /
      Last update: 2009-10-26 08:45    [W:0.022 / U:30.640 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site