lkml.org 
[lkml]   [2009]   [Oct]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[tip:core/rcu] rcu: Improve rcutorture diagnostics when bad torture_type specified
    Commit-ID:  cf886c44ec418a01b2c52493465accb81acbf930
    Gitweb: http://git.kernel.org/tip/cf886c44ec418a01b2c52493465accb81acbf930
    Author: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
    AuthorDate: Sun, 25 Oct 2009 19:03:54 -0700
    Committer: Ingo Molnar <mingo@elte.hu>
    CommitDate: Mon, 26 Oct 2009 09:40:31 +0100

    rcu: Improve rcutorture diagnostics when bad torture_type specified

    Make rcutorture list the available torture_type values when it
    doesn't like the one specified.

    Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
    Acked-by: Josh Triplett <josh@joshtriplett.org>
    Reviewed-by: Lai Jiangshan <laijs@cn.fujitsu.com>
    Cc: dipankar@in.ibm.com
    Cc: mathieu.desnoyers@polymtl.ca
    Cc: dvhltc@us.ibm.com
    Cc: niv@us.ibm.com
    Cc: peterz@infradead.org
    Cc: rostedt@goodmis.org
    Cc: Valdis.Kletnieks@vt.edu
    Cc: dhowells@redhat.com
    Cc: avi@redhat.com
    Cc: mtosatti@redhat.com
    LKML-Reference: <12565226351868-git-send-email->
    Signed-off-by: Ingo Molnar <mingo@elte.hu>
    ---
    kernel/rcutorture.c | 6 +++++-
    1 files changed, 5 insertions(+), 1 deletions(-)

    diff --git a/kernel/rcutorture.c b/kernel/rcutorture.c
    index 14480e8..3dd0ca2 100644
    --- a/kernel/rcutorture.c
    +++ b/kernel/rcutorture.c
    @@ -1129,8 +1129,12 @@ rcu_torture_init(void)
    break;
    }
    if (i == ARRAY_SIZE(torture_ops)) {
    - printk(KERN_ALERT "rcutorture: invalid torture type: \"%s\"\n",
    + printk(KERN_ALERT "rcu-torture: invalid torture type: \"%s\"\n",
    torture_type);
    + printk(KERN_ALERT "rcu-torture types:");
    + for (i = 0; i < ARRAY_SIZE(torture_ops); i++)
    + printk(KERN_ALERT " %s", torture_ops[i]->name);
    + printk(KERN_ALERT "\n");
    mutex_unlock(&fullstop_mutex);
    return -EINVAL;
    }

    \
     
     \ /
      Last update: 2009-10-26 12:41    [W:0.021 / U:1.364 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site