lkml.org 
[lkml]   [2009]   [Oct]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 6/9] ser_gigaset: checkpatch cleanup
On Sun, 25 Oct 2009 20:30:27 +0100 (CET)
Tilman Schmidt <tilman@imap.cc> wrote:

> Duly uglified as demanded by checkpatch.pl.
>
> Impact: cosmeti

Umm ??

> - if (!(bcs->tx_skb = skb_dequeue(&bcs->squeue)))
> + nextskb = skb_dequeue(&bcs->squeue);
> + if (!nextskb)
> /* no skb either, nothing to do */
> return;
> + bcs->tx_skb = nextskb;

This does not do the same thing as before

Previously the NULL case assigned to bcs->tx_skb, now it does not.


\
 
 \ /
  Last update: 2009-10-25 21:37    [from the cache]
©2003-2011 Jasper Spaans