lkml.org 
[lkml]   [2009]   [Oct]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC/PATCH] ratelimit: make output more useful

* Christian Borntraeger <borntraeger@de.ibm.com> wrote:

> Am Freitag 23 Oktober 2009 13:33:48 schrieb Ingo Molnar:
> > Mind sending it against latest tip:master (or tip:core/printk):
> [...]
> > Which has a couple of ratelimit changes queued up already that collide
> > with your patch:
>
> Sure, something like the following?
>
> [PATCH] ratelimit: make output more useful
>
> Today I got
>
> [39648.224782] Registered led device: iwl-phy0::TX
> [40676.545099] __ratelimit: 246 callbacks suppressed
> [40676.545103] abcdef[23675]: segfault at 0 ...

btw., an effect of this will be a small amount of extra bloat at every
callsite of printk_ratelimit(). There's 200 of them kernel-wide, so i
guess it's OK as all these codepaths are atypical slowpaths already.

Ingo


\
 
 \ /
  Last update: 2009-10-23 15:13    [W:0.097 / U:0.656 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site