Messages in this thread | | | Date | Fri, 23 Oct 2009 15:11:14 +0200 | From | Ingo Molnar <> | Subject | Re: [RFC/PATCH] ratelimit: make output more useful |
| |
* Christian Borntraeger <borntraeger@de.ibm.com> wrote:
> Am Freitag 23 Oktober 2009 13:33:48 schrieb Ingo Molnar: > > Mind sending it against latest tip:master (or tip:core/printk): > [...] > > Which has a couple of ratelimit changes queued up already that collide > > with your patch: > > Sure, something like the following? > > [PATCH] ratelimit: make output more useful > > Today I got > > [39648.224782] Registered led device: iwl-phy0::TX > [40676.545099] __ratelimit: 246 callbacks suppressed > [40676.545103] abcdef[23675]: segfault at 0 ...
btw., an effect of this will be a small amount of extra bloat at every callsite of printk_ratelimit(). There's 200 of them kernel-wide, so i guess it's OK as all these codepaths are atypical slowpaths already.
Ingo
| |