Messages in this thread | | | From | Lucas De Marchi <> | Date | Fri, 23 Oct 2009 23:07:38 -0200 | Subject | Re: [PATCH] perf tools: add compatibility with libelf 0.8 and autodetect |
| |
On Fri, Oct 23, 2009 at 19:48, Marti Raudsepp <marti@juffo.org> wrote: > On Sat, Oct 24, 2009 at 12:02 AM, Ingo Molnar <mingo@elte.hu> wrote: >> Mind doing a small change: >> >> I think we want a small cleanup here: a perf_elf_begin() wrapper in a >> header file to hide this #ifdef. (That's how Git wraps environmental >> libraries as well.) > Why don't you do something like?:
#ifdef LIBELF_NO_MMAP #define ELF_C_READ_MMAP ELF_C_READ #endif + changes to Makefile
or:
#ifndef ELF_C_READ_MMAP #define ELF_C_READ_MMAP ELF_C_READ #endif
| |