lkml.org 
[lkml]   [2009]   [Oct]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] bluetooth: remove useless variable in virtual hci driver
Date
Commit ac28494c has removed the option to give a minor number as
parameter for VHCI driver. Remove the variable used for that parameter.
Print the error code when registering the device fails, instead of the
requested minor number (which would always be MISC_DYNAMIC_MINOR).

Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com>
---
drivers/bluetooth/hci_vhci.c | 17 ++++++++++-------
1 files changed, 10 insertions(+), 7 deletions(-)

diff --git a/drivers/bluetooth/hci_vhci.c b/drivers/bluetooth/hci_vhci.c
index d5cde6d..74c094c 100644
--- a/drivers/bluetooth/hci_vhci.c
+++ b/drivers/bluetooth/hci_vhci.c
@@ -41,8 +41,6 @@

#define VERSION "1.3"

-static int minor = MISC_DYNAMIC_MINOR;
-
struct vhci_data {
struct hci_dev *hdev;

@@ -292,7 +290,7 @@ static const struct file_operations vhci_fops = {
.release = vhci_release,
};

-static struct miscdevice vhci_miscdev= {
+static struct miscdevice vhci_miscdev = {
.name = "vhci",
.fops = &vhci_fops,
.minor = MISC_DYNAMIC_MINOR,
@@ -300,10 +298,13 @@ static struct miscdevice vhci_miscdev= {

static int __init vhci_init(void)
{
+ int r;
+
BT_INFO("Virtual HCI driver ver %s", VERSION);

- if (misc_register(&vhci_miscdev) < 0) {
- BT_ERR("Can't register misc device with minor %d", minor);
+ r = misc_register(&vhci_miscdev);
+ if (r < 0) {
+ BT_ERR("Can't register misc device: %d", r);
return -EIO;
}

@@ -312,8 +313,10 @@ static int __init vhci_init(void)

static void __exit vhci_exit(void)
{
- if (misc_deregister(&vhci_miscdev) < 0)
- BT_ERR("Can't unregister misc device with minor %d", minor);
+ int r;
+ r = misc_deregister(&vhci_miscdev);
+ if (r < 0)
+ BT_ERR("Can't unregister misc device: %d", r);
}

module_init(vhci_init);
--
1.6.3.3


\
 
 \ /
  Last update: 2009-10-24 01:31    [W:0.106 / U:0.064 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site