Messages in this thread | | | Date | Fri, 23 Oct 2009 10:00:07 -0700 | From | Jeremy Fitzhardinge <> | Subject | Re: [PATCH] dmi_check_system can generate Warnings when no DMI table is present |
| |
On 10/23/09 08:30, Ingo Molnar wrote: >> Ingo mentioned that the returning mechanism your adding was left out >> intentionally to catch this error, so I don't think your original >> patch could be included .. >> > Yes. That mechanism found a real bug here. > > Calling the DMI code too early (when the strings are still empty) can > cause silent failures: we wont crash but we might miss to act on DMI > quirks. >
Yes. There's nothing preventing the DMI subsystem from being initialized under Xen; in fact we rely on it in a dom0 kernel (which does have access to the DMI tables). I don't know what the underlying bug in the original report is, but there's more to it than failing to init DMI.
J
| |