Messages in this thread | | | Date | Thu, 22 Oct 2009 06:57:22 -0700 | From | Matt Helsley <> | Subject | Re: [RFC][v8][PATCH 9/10]: Define clone3() syscall |
| |
On Thu, Oct 22, 2009 at 02:14:16PM +0200, Michael Kerrisk wrote: > Peter, > > On Thu, Oct 22, 2009 at 1:38 PM, H. Peter Anvin <hpa@zytor.com> wrote: > > On 10/22/2009 07:26 PM, Michael Kerrisk wrote: > >>> > >>> "3" is number of arguments. > >> > >> sys_clone3(struct clone_struct __user *ucs, pid_t __user *pids) > >> > >> It appears to me that the number of arguments is 2. > >> > > > > It was 3 at one point... I'm not sure when that changed last :-/ > > > >>> It's better than "extended" or something like > >>> that simply because "extended" just means "more than", and a number at > >>> least > >>> tells you *how much more than*. > >> > >> I'm not sure why you think including a number in the name tells us > >> "how much more than". Unless you are considering the numbering to be > >> version numbers, which apparently is not what you mean. > > > > It is a version number of sorts. > > So, sometimes, a number in a system call should be the bit width of > some arguments(s), sometimes it should be the number of arguments, and > sometimes (well, just occasionally, as in mmap2() and clone()) -- it > should be a version number? Does the weather play any part in the
In this case 3 could be both the number of arguments and the version number (clone, clone2, clone3). Match 2 conventions with one choice of name. :)
Cheers, -Matt Helsley
| |