[lkml]   [2009]   [Oct]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [RFC Patch] use MTRR for write combining if PAT is not available
    Suresh Siddha wrote:
    > I think we can simplify this by just using mtrr_add_page() and avoid
    > all the complexity that comes with mtrr_add_unaligned().
    > pci_mmap_range() should call one mtrr_add_page() if the base and size
    > are nicely aligned. Almost all the cases, this is the usage sequence
    > here anyway.

    Ingo Molnar wrote:
    > Can we eliminate mtrr_add_unaligned() as Suresh suggested, and still
    > make it work on your testbox?

    Yes, I had that in the first place, but Jan suggested to extend it to also
    handle non-aligned, non-power-of-two cases:

    So if it's OK for Jan, I'll reduce the functionality again and use mtrr_add()
    instead. Btw. this simply means to drop mtrr_add_unaligned(), all the other
    parts are still required for reference counting and a proper mtrr_del() on file

    Kind regards,

     \ /
      Last update: 2009-10-21 15:47    [W:0.028 / U:5.908 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site