Messages in this thread | | | From | Arnd Bergmann <> | Subject | Re: [PATCH] sony_pi: Remove the BKL from sonypi_misc_open | Date | Wed, 21 Oct 2009 15:16:20 +0200 |
| |
On Wednesday 21 October 2009, John Kacur wrote: > From 96872f13a510db69fbb32f9e956615cd826f8986 Mon Sep 17 00:00:00 2001 > From: John Kacur <jkacur@redhat.com> > Date: Sun, 18 Oct 2009 23:49:49 +0200 > Subject: [PATCH] sony_pi: Remove the BKL from open and ioctl > > The BKL is in this function because of the BKL pushdown > (see commit f8f2c79d594463427f7114cedb1555110d547d89) > > It is not needed here because the mutex_lock sonypi_device.lock > provides the necessary locking. > > sonpi_misc_ioctl can be converted to unlocked ioctls since it relies on > its own locking (the mutex sonypi_device.lock) and not the bkl > > Document that llseek is not needed by explictly setting it to no_llseek > > Signed-off-by: John Kacur <jkacur@redhat.com>
Acked-by: Arnd Bergmann <arnd@arndb.de>
This looks perfect to me now. Just a few hundred more of these, and we're done with the drivers ;-)
| |