Messages in this thread | | | Date | Thu, 22 Oct 2009 02:44:26 +0200 | From | Andi Kleen <> | Subject | Re: [RFC][PATCH] Add prctl to set sibling thread names |
| |
On Wed, Oct 21, 2009 at 05:42:15PM -0700, john stultz wrote: > On Thu, 2009-10-22 at 02:28 +0200, Andi Kleen wrote: > > On Wed, Oct 21, 2009 at 04:21:37PM -0700, john stultz wrote: > > > > > > Taking a very raw attempt at this, I scratched out the following simple > > > implementation. I'd appreciate any review or suggestions for > > > improvements. I'm not at all certain the passing of the thread pid_t > > > through the unsigned long is valid, for instance, or if > > > same_thread_group() is the right check to make sure we only change > > > siblings and not tid from other processes. So any advice on better > > > approaches would be great. > > > > First though that comes to mind is that this should not be in prctl() > > So it deserves a new syscall? Any other thoughts?
I would probably just put it into /proc/pid and use the normal ptrace access checks. -Andi
-- ak@linux.intel.com -- Speaking for myself only.
| |