Messages in this thread Patch in this message | | | Date | Wed, 21 Oct 2009 15:43:37 -0700 | From | Greg KH <> | Subject | Re: [PATCH] Fix null pointer error after vmbus loading |
| |
On Wed, Oct 21, 2009 at 07:24:23PM +0000, Haiyang Zhang wrote: > From: Haiyang Zhang <haiyangz@microsoft.com> > > Fix null pointer error after vmbus loading. > > Cc: Greg Kroah-Hartman <gregkh@suse.de> > Signed-off-by: Hank Janssen <hjanssen@microsoft.com> > Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com> > > --- > diff --git a/drivers/staging/hv/vmbus_drv.c b/drivers/staging/hv/vmbus_drv.c > index 582318f..11431cc 100644 > --- a/drivers/staging/hv/vmbus_drv.c > +++ b/drivers/staging/hv/vmbus_drv.c > @@ -538,9 +538,10 @@ static int vmbus_child_device_register(struct hv_device *root_device_obj, > child_device_ctx); > > /* Make sure we are not registered already */ > - if (strlen(dev_name(&child_device_ctx->device)) != 0) { > + if (dev_name(&child_device_ctx->device) != NULL && > + strlen(dev_name(&child_device_ctx->device)) != 0) {
Why would the device name ever be NULL? Why would you need to check it here?
confused,
greg k-h
| |