[lkml]   [2009]   [Oct]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Patch in this message
Subject[PATCH] net: Adjust softirq raising in __napi_schedule
On Wed, Oct 21, 2009 at 08:46:40PM +0200, Tilman Schmidt wrote:
> I have tested your patch and I can confirm that it fixes the messages.
> I have not noticed any ill effects.

OK. So, in any case, here is this next variant/proposal.

Jarek P.
net: Adjust softirq raising in __napi_schedule

This patch changes __raise_softirq_irqoff() to raise_softirq_irqoff()
in __napi_schedule() to enable proper softirq scheduling from process
context. The main intent is to let use netif_rx() universally, and
make netif_rx_ni() redundant.

Currently using netif_rx() instead of netif_rx_ni() triggers:
"NOHZ: local_softirq_pending 08" warnings, but additional cost of one
"if" on the fast path doesn't seem to justify maintaining it

This patch is based on the analysis, suggestions and the original
patch for mac80211 by: Michael Buesch <>

Another patch calling netif_rx variants conditionally was done by:
Oliver Hartkopp <>

Reported-by: Michael Buesch <>
Reported-by: Oliver Hartkopp <>
Reported-by: Tilman Schmidt <>
Diagnosed-by: Michael Buesch <>
Tested-by: Tilman Schmidt <>
Signed-off-by: Jarek Poplawski <>

net/core/dev.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/net/core/dev.c b/net/core/dev.c
index 28b0b9e..7fc4009 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -2728,7 +2728,7 @@ void __napi_schedule(struct napi_struct *n)

list_add_tail(&n->poll_list, &__get_cpu_var(softnet_data).poll_list);
- __raise_softirq_irqoff(NET_RX_SOFTIRQ);
+ raise_softirq_irqoff(NET_RX_SOFTIRQ);

 \ /
  Last update: 2009-10-21 23:21    [W:0.109 / U:5.768 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site