lkml.org 
[lkml]   [2009]   [Oct]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [RFC V2 PATCH 2/5] cfq-iosched: preparation to handle multiple service trees
Date
Corrado Zoccolo <czoccolo@gmail.com> writes:

> We embed a pointer to the service tree in each queue, to handle multiple
> service trees easily.
> Service trees are enriched with a counter.
> cfq_add_rq_rb is invoked after putting the rq in the fifo, to ensure
> that all fields in rq are properly initialized.
>
> @@ -115,6 +116,9 @@ struct cfq_queue {
> unsigned short ioprio_class, org_ioprio_class;
>
> pid_t pid;
> +
> + struct cfq_rb_root *service_tree;
> + struct cfq_io_context *cic;
> };

This change worries me. For async queues, there is not a 1:1 mapping
between cfqq and cic. With my forthcoming close cooperator changes, the
same will be true for sync queues.

Cheers,
Jeff


\
 
 \ /
  Last update: 2009-10-21 17:35    [from the cache]
©2003-2011 Jasper Spaans