Messages in this thread | | | Date | Fri, 2 Oct 2009 09:20:21 +0000 | From | Frederik Deweerdt <> | Subject | Re: [PATCH][UHCI-DEBUG] Don't kmalloc with BKL held |
| |
Hi Sven-Thorsten,
On Fri, Oct 02, 2009 at 11:12:24AM +0200, Sven-Thorsten Dietrich wrote: > Subject: Don't kmalloc with BKL held. > From: Sven-Thorsten Dietrich <sdietrich@suse.de> > > I'm eyeballing this file for complete removal of lock_kernel but > at first glance, we definitely don't need BKL to kmalloc(). You need to move the unlock_kernel() above the out: label too.
Regards, Frederik
> > Signed-off-by: Sven-Thorsten Dietrich <sdietrich@suse.de> > > > diff --git a/drivers/usb/host/uhci-debug.c b/drivers/usb/host/uhci-debug.c > index e52b954..325d508 100644 > --- a/drivers/usb/host/uhci-debug.c > +++ b/drivers/usb/host/uhci-debug.c > @@ -497,7 +497,6 @@ static int uhci_debug_open(struct inode *inode, struct file *file) > int ret = -ENOMEM; > unsigned long flags; > > - lock_kernel(); > up = kmalloc(sizeof(*up), GFP_KERNEL); > if (!up) > goto out; > @@ -509,6 +508,8 @@ static int uhci_debug_open(struct inode *inode, struct file *file) > } > > up->size = 0; > + > + lock_kernel(); > spin_lock_irqsave(&uhci->lock, flags); > if (uhci->is_initialized) > up->size = uhci_sprint_schedule(uhci, up->data, MAX_OUTPUT); > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/
| |