Messages in this thread | | | Date | Fri, 2 Oct 2009 22:12:08 +0200 | From | Andi Kleen <> | Subject | Re: [PATCH] x86: Use __builtin_memset and __builtin_memcpy for memset/memcpy |
| |
On Fri, Oct 02, 2009 at 01:04:25PM -0700, H. Peter Anvin wrote: > On 10/02/2009 12:19 PM, Andi Kleen wrote: > > > > I tried this some time ago, but it it generates bad code on some > > gcc 3 versions. > > > > You really need to test such kind of changes on a wide variety > > of compilers, not assuming everyone uses the same version as you. > > > > The version that went in is for gcc 4 only.
Thanks.
My memory might be faulty, but iirc 4.0/4.1 was also slightly problematic. So better take a look at code for that too if you haven't yet (just code size numbers are not enough)
-Andi
-- ak@linux.intel.com -- Speaking for myself only.
| |