Messages in this thread Patch in this message | | | From | (Eric W. Biederman) | Date | Thu, 01 Oct 2009 23:06:11 -0700 | Subject | Re: [000/136] 2.6.31.2-stable review |
| |
Greg KH <gregkh@suse.de> writes:
> On Thu, Oct 01, 2009 at 10:01:34PM -0700, Eric W. Biederman wrote: >> Greg KH <gregkh@suse.de> writes: >> >> > Note from the -stable maintainer on this release: >> > >> > This release is big. Yeah, really big. There are a number of >> > areas that needed some rework in order to get things back to >> > working order. Like the tty layer. Hopefully everyone can now >> > use their usb to serial devices again without oopsing the >> > kernel >> >> The ftdi_sio driver still crashes and burns. > > What were you doing when it crashed? I tested the pl2303 device and it > worked fine for me here, I don't have a ftdi_sio one :(
The patch that floated on the list earlier does fix the worst of the symptoms.
Eric
From: Johan Hovold <jhovold@gmail.com> Subject: [PATCH] USB: ftdi_sio: Remove tty->low_latency.
Fixes tty_flip_buffer_push being called from hard interrupt context with low_latency set.
Signed-off-by: Johan Hovold <jhovold@gmail.com> --- drivers/usb/serial/ftdi_sio.c | 4 ---- 1 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/drivers/usb/serial/ftdi_sio.c b/drivers/usb/serial/ftdi_sio.c index 8fec5d4..22b72e8 100644 --- a/drivers/usb/serial/ftdi_sio.c +++ b/drivers/usb/serial/ftdi_sio.c @@ -1228,7 +1228,6 @@ static int set_serial_info(struct tty_struct *tty, (new_serial.flags & ASYNC_FLAGS)); priv->custom_divisor = new_serial.custom_divisor; - tty->low_latency = (priv->flags & ASYNC_LOW_LATENCY) ? 1 : 0; write_latency_timer(port); check_and_exit: @@ -1699,9 +1698,6 @@ static int ftdi_open(struct tty_struct *tty, priv->rx_bytes = 0; spin_unlock_irqrestore(&priv->rx_lock, flags); - if (tty) - tty->low_latency = (priv->flags & ASYNC_LOW_LATENCY) ? 1 : 0; - write_latency_timer(port); /* No error checking for this (will get errors later anyway) */ -- 1.6.2.5
| |