Messages in this thread | | | Date | Fri, 02 Oct 2009 08:20:17 -0500 | From | Paul Fulghum <> | Subject | Re: [PATCH] drivers/char/pcmcia/synclink_cs.c: BKL pushdown? |
| |
Alan Cox wrote: > On Fri, 02 Oct 2009 19:37:21 +0900 > lenrek@me.com wrote: > >> I found the counterpart of function mgslpc_wait_until_sent >> in drivers/char/synclinkmp.c (wait_until_sent) is modified to >> issue (un)lock_kernel. This patch does the same modification. >> >> However, I'm afraid similar modifications are necessary further on >> functions >> mgslpc_ioctl and mgslpc_write_room. > > The push down work normally eliminated BKL calls that were demonstrably > not needed and left it in anywhere that needed thought. Do those > functions still really need the BKL ?
No, these functions use a device specific spinlock (info->lock) when needed. Not even mgslpc_wait_until_sent needs BKL.
-- Paul Fulghum MicroGate Systems, Ltd. =Customer Driven, by Design= (800)444-1982 (512)345-7791 (Direct) (512)343-9046 (Fax) Central Time Zone (GMT -5h) www.microgate.com
| |