Messages in this thread | | | Date | Mon, 19 Oct 2009 11:16:17 +0200 | From | Andreas Mohr <> | Subject | Re: [Patch] acerhdf: Return temperature in milidegree |
| |
Hi,
On Mon, Oct 19, 2009 at 10:21:16AM +0200, Peter Feuerer wrote: > > Hi Boris, > > what do you think about this patch?
Personally I'm hurting a bit due to the open-coded "* 1000" transition in all places.
I'd add a helper macro #define TEMP_DEGREE_TO_SYS(x) ((x) * 1000) and use that in all places where it matters.
Advantage: - either no mistyping (10000 instead of 1000) _or_ bug occurring in _all_ places where this macro is used - easily grepped-for - easily changed once the system granularity gets updated
Andreas Mohr
| |