lkml.org 
[lkml]   [2009]   [Oct]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH] amd64_edac: fix a wrong goto clause in amd64_edac.c
    In amd64_edac_init(void) in amd64_edac.c, cache_k8_northbridges() is called
    before pci_register_driver. If it fails, should exit with err directly.

    Signed-off-by: Li Hong <lihong.hi@gmail.com>
    ---
    drivers/edac/amd64_edac.c | 4 +---
    1 files changed, 1 insertions(+), 3 deletions(-)

    diff --git a/drivers/edac/amd64_edac.c b/drivers/edac/amd64_edac.c
    index d4560d9..3ee539a 100644
    --- a/drivers/edac/amd64_edac.c
    +++ b/drivers/edac/amd64_edac.c
    @@ -3163,7 +3163,7 @@ static int __init amd64_edac_init(void)
    opstate_init();

    if (cache_k8_northbridges() < 0)
    - goto err_exit;
    + return err;

    err = pci_register_driver(&amd64_pci_driver);
    if (err)
    @@ -3189,8 +3189,6 @@ static int __init amd64_edac_init(void)

    err_2nd_stage:
    debugf0("2nd stage failed\n");
    -
    -err_exit:
    pci_unregister_driver(&amd64_pci_driver);

    return err;
    --
    1.6.0.4


    \
     
     \ /
      Last update: 2009-10-19 10:43    [W:0.020 / U:64.536 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site