Messages in this thread Patch in this message | | | Date | Mon, 19 Oct 2009 10:39:34 +0200 | From | Ingo Molnar <> | Subject | [PATCH] nfs: Fix nfs_parse_mount_options() kfree() leak |
| |
* Trond Myklebust <trond.myklebust@fys.uio.no> wrote:
> > So d508afb fixed all that needed fixing and there's nothing serious > > pending here. I've reverted all pending bits in tip:out-of-tree, so > > it's pure -git now. I rarely have to carry any NFS fixes in > > out-of-tree, this was an odd-one-out exception that fell through the > > cracks. > > > > Ingo > > OK. Could you resend the remaining leak fix, with the fixed up > changelog and attributions so I can pass it on to Linus?
Sure - find it below.
Thanks,
Ingo
--------------------------------------------> From 42497c08be18c388f696a692ca5f8c3ba48cb183 Mon Sep 17 00:00:00 2001 From: Yinghai Lu <yinghai@kernel.org> Date: Fri, 3 Apr 2009 09:06:15 +0200 Subject: [PATCH] nfs: Fix nfs_parse_mount_options() kfree() leak
Fix a (small) memory leak in one of the error paths of the NFS mount options parsing code.
Reported-by: Yinghai Lu <yinghai@kernel.org> Reported-by: Pekka Enberg <penberg@cs.helsinki.fi> Signed-off-by: Ingo Molnar <mingo@elte.hu> --- fs/nfs/super.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/fs/nfs/super.c b/fs/nfs/super.c index a2c18ac..90be551 100644 --- a/fs/nfs/super.c +++ b/fs/nfs/super.c @@ -1253,6 +1253,7 @@ static int nfs_parse_mount_options(char *raw, default: dfprintk(MOUNT, "NFS: unrecognized " "transport protocol\n"); + kfree(string); return 0; } break;
| |