Messages in this thread | | | Date | Tue, 20 Oct 2009 07:30:39 +0900 | From | Mattia Dongili <> | Subject | Re: [PATCH] sony_pi: Remove the BKL from sonypi_misc_open |
| |
On Tue, Oct 20, 2009 at 12:00:24AM +0200, Arnd Bergmann wrote: > On Monday 19 October 2009, John Kacur wrote: > > How does this look? (Version 2 of the patch follows) > > Looks good now.
Looks alright to me too.
> > From efd07cfcd021b4438d83d383ab81f9b35cb41eb9 Mon Sep 17 00:00:00 2001 > > From: John Kacur <jkacur@redhat.com> > > Date: Sun, 18 Oct 2009 23:49:49 +0200 > > Subject: [PATCH] sony_pi: Remove the BKL from sonypi_misc_open > > > > The BKL is in this function because of the BKL pushdown > > (see commit f8f2c79d594463427f7114cedb1555110d547d89) > > > > It is not needed here because the mutex_lock sonypi_device.lock > > provides the necessary locking. > > > > sonpi_misc_ioctl can be converted to unlocked ioctls since it relies on > > its own locking (the mutex sonypi_device.lock) and not the bkl > > > > Signed-off-by: John Kacur <jkacur@redhat.com> > > Acked-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Mattia Dongili <malattia@linux.it> -- mattia :wq!
| |