lkml.org 
[lkml]   [2009]   [Oct]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH 2/5] mm: refactor register_cpu_under_node()
    From
    Date
    By returning early if the node is not online, we can unindent the
    interesting code by one level.

    No functional change.

    Signed-off-by: Alex Chiang <achiang@hp.com>
    ---

    drivers/base/node.c | 20 +++++++++++---------
    1 files changed, 11 insertions(+), 9 deletions(-)

    diff --git a/drivers/base/node.c b/drivers/base/node.c
    index 3108b21..ef7dd22 100644
    --- a/drivers/base/node.c
    +++ b/drivers/base/node.c
    @@ -227,16 +227,18 @@ struct node node_devices[MAX_NUMNODES];
    */
    int register_cpu_under_node(unsigned int cpu, unsigned int nid)
    {
    - if (node_online(nid)) {
    - struct sys_device *obj = get_cpu_sysdev(cpu);
    - if (!obj)
    - return 0;
    - return sysfs_create_link(&node_devices[nid].sysdev.kobj,
    - &obj->kobj,
    - kobject_name(&obj->kobj));
    - }
    + struct sys_device *obj;

    - return 0;
    + if (!node_online(nid))
    + return 0;
    +
    + obj = get_cpu_sysdev(cpu);
    + if (!obj)
    + return 0;
    +
    + return sysfs_create_link(&node_devices[nid].sysdev.kobj,
    + &obj->kobj,
    + kobject_name(&obj->kobj));
    }

    int unregister_cpu_under_node(unsigned int cpu, unsigned int nid)


    \
     
     \ /
      Last update: 2009-10-19 23:37    [W:0.025 / U:59.224 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site