lkml.org 
[lkml]   [2009]   [Oct]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 5/7] mfd: pcf50633: Cleanup pcf50633_probe error handling
    Hi Paul,

    On Wed, Oct 14, 2009 at 02:12:34AM +0400, Paul Fertser wrote:
    > From: Lars-Peter Clausen <lars@metafoo.de>
    >
    > Currently the child devices were not freed if the irq could not be requested.
    > This patch restructures the function, that in case of an error all previously
    > allocated resources are freed.
    >
    > Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
    > Signed-off-by: Paul Fertser <fercerpav@gmail.com>
    > ---
    > drivers/mfd/pcf50633-core.c | 47 +++++++++++++++++++++++++-----------------
    > 1 files changed, 28 insertions(+), 19 deletions(-)
    [...]
    > if (enable_irq_wake(client->irq) < 0)
    > - dev_err(pcf->dev, "IRQ %u cannot be enabled as wake-up source"
    > + dev_info(pcf->dev, "IRQ %u cannot be enabled as wake-up source"
    > "in this hardware revision", client->irq);
    2 things here: This doesnt really belong to this patch, and also I'd prefer to
    keep that as an error message.


    > ret = sysfs_create_group(&client->dev.kobj, &pcf_attr_group);
    > if (ret)
    > - dev_err(pcf->dev, "error creating sysfs entries\n");
    > + dev_info(pcf->dev, "Failed to create sysfs entries\n");
    Same here.

    Otherwise, this patch looks good to me.



    --
    Intel Open Source Technology Centre
    http://oss.intel.com/


    \
     
     \ /
      Last update: 2009-10-19 17:09    [W:0.020 / U:2.196 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site