Messages in this thread | | | From | Peter Ujfalusi <> | Subject | Re: [PATCH 3/4] ASoC: TWL4030: Only update the needed bits in *set_dai_sysclk | Date | Mon, 19 Oct 2009 15:59:38 +0300 |
| |
On Monday 19 October 2009 15:55:08 ext Mark Brown wrote: > On Mon, Oct 19, 2009 at 03:42:19PM +0300, Peter Ujfalusi wrote: > > + apll_ctrl = twl4030_read_reg_cache(codec, TWL4030_REG_APLL_CTL); > > + apll_ctrl &= ~TWL4030_APLL_INFREQ; > > switch (freq) { > > I'll apply this - it's idiomatic for the current driver - but you might > want to look at snd_soc_update_bits() which does a read/modify/write > cycle for you. >
Yeah, it is a good idea. I'll address this when I go through the soc codec driver in my planned revisit and cleanup round quite soon.
Thanks, Péter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |